[webkit-reviews] review granted: [Bug 27513] [Chromium] Linux: add static functions to FontPlatformData which allow for setting the global font rendering preferences. : [Attachment 33229] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 22 07:24:21 PDT 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Langley
<agl at chromium.org>'s request for review:
Bug 27513: [Chromium] Linux: add static functions to FontPlatformData which
allow for setting the global font rendering preferences.
https://bugs.webkit.org/show_bug.cgi?id=27513

Attachment 33229: patch
https://bugs.webkit.org/attachment.cgi?id=33229&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +    static void setHinting(SkPaint::Hinting);
> +    static void setAntiAlias(bool on);
> +    static void setSubpixelGlyphs(bool on);

nit: i think webkit style is to leave these bool parameters unnamed.

otherwise, r=me


More information about the webkit-reviews mailing list