[webkit-reviews] review requested: [Bug 27526] Inspector: Removing an Attribute via Edit should Delete the Attribute, Not Ignore Your Changes : [Attachment 33231] Removing an Attribute Deletes the Attribute - And Fix Possible Exception

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27526: Inspector: Removing an Attribute via Edit should Delete the
Attribute, Not Ignore Your Changes
https://bugs.webkit.org/show_bug.cgi?id=27526

Attachment 33231: Removing an Attribute Deletes the Attribute - And Fix
Possible Exception
https://bugs.webkit.org/attachment.cgi?id=33231&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
NOTES:

1. This will delete an attribute _if_ that attribute previously existed.  The
only time an attribute would not previously exist would be if it is a "new"
attribute.  This means this is compatible with the (uncommitted) patch on the
following bug to create new attributes:
https://bugs.webkit.org/show_bug.cgi?id=21108

2. This fixes an error that has been around for a while where an invalid
attribute from user input (such as "-") can cause an error.  An example test
case will be attached in a minute.