[webkit-reviews] review denied: [Bug 27524] Add check for correct wtf includes in WebCore to cpplint : [Attachment 33225] Add check for correct wtf includes in WebCore to cpplint

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27524: Add check for correct wtf includes in WebCore to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27524

Attachment 33225: Add check for correct wtf includes in WebCore to cpplint
https://bugs.webkit.org/attachment.cgi?id=33225&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKitTools/Scripts/modules/cpplint.py
b/WebKitTools/Scripts/modules/cpplint.py
> +	   # Check specific include file rules.
> +	   if filename != "-":

When is the filename "-" ?

> +	       filepath = os.path.abspath(filename)
> +	       filepath_parts = filepath.split(os.sep)
> +	       if 'WebCore' in filepath_parts:

Why only WebCore? I think this is true in all directories. (And if it should
only be WebCore, please add a test for this.)



>