[webkit-reviews] review denied: [Bug 22784] [Chromium] Home, End, PageUp and PageDown buttons do not do anything in drop down lists : [Attachment 33224] Updated patch with test case

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 22784: [Chromium] Home, End, PageUp and PageDown buttons do not do anything
in drop down lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 33224: Updated patch with test case
https://bugs.webkit.org/attachment.cgi?id=33224&action=review

------- Additional Comments from David Levin <levin at chromium.org>
A few small changes and this will be done :)

> --- LayoutTests/fast/forms/select-popup-pagekeys-expected.txt (revision 0)

> +This test verifies that the Home/End/PageUp/PageDown keys work correctly for
pop-up <select> elements that have focus but are not currently popped-up.
> +

The tests typically note here what one should see if running it in the browser.
 (Some thing like.  Below you should see some information about the key pressed
and whether a test passed followed by a single "SUCCESS".)


The expected output here doesn't match what I would expect from the html. (It
is missing "NOTE: This test will fail on Mac OS, on which these keys are NOT
supposed to change the selection of a focused pop-up."


> \ No newline at end of file

Please add a newline (I guess fix the html file to ensure that there is one.)


> Property changes on:
LayoutTests/fast/forms/select-popup-pagekeys-expected.txt
> ___________________________________________________________________
> Name: svn:eol-style:native

Please set to LF.


> Index: LayoutTests/fast/forms/select-popup-pagekeys.html
> \ No newline at end of file

Please add a newline.

> Index: LayoutTests/platform/mac/fast/forms/select-popup-pagekeys-expected.txt

> ___________________________________________________________________
> Name: svn:eol-style:native

Please set to LF.