[webkit-reviews] review denied: [Bug 24333] execCommand('underline') can modify DOM outside of the contentEditable area : [Attachment 33120] highestAncestorWithTextDecoration stops at an unsplittable element, and improves other text decorations support
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 21 15:59:55 PDT 2009
Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 24333: execCommand('underline') can modify DOM outside of the
contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333
Attachment 33120: highestAncestorWithTextDecoration stops at an unsplittable
element, and improves other text decorations support
https://bugs.webkit.org/attachment.cgi?id=33120&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
This makes unrelated, possibly incorrect changes. Please break this into
multiple patches with individual test cases.
See the test case on https://bugs.webkit.org/show_bug.cgi?id=20215, I think you
may have broken some of those cases here.
More information about the webkit-reviews
mailing list