[webkit-reviews] review denied: [Bug 27516] Add onerror to WorkerContext. : [Attachment 33214] Proposed Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 27516: Add onerror to WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27516

Attachment 33214: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33214&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few things to clean up.


> diff --git a/WebCore/workers/WorkerContext.h
b/WebCore/workers/WorkerContext.h

> +	   RefPtr<EventListener> m_onErrorListener;

Should be "m_onerrorListener" because onerror seems to consistently treated as
one word.



> diff --git a/WebCore/workers/WorkerContext.idl
b/WebCore/workers/WorkerContext.idl
>  #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> -		    attribute [Replaceable] WorkerContext self;
> +	   attribute [Replaceable] WorkerContext self;

Don't unindent these.  The idl formatting leaves room for "readonly " when it
isn't present which is why these are indented to this level.

>  #endif
> -		    attribute [Replaceable] WorkerLocation location;
> +	   attribute [Replaceable] WorkerLocation location;

Same unindenting comment.

>	   void close();
> -	   //	      attribute EventListener onerror;
> +	   attribute EventListener onerror;

Just uncomment but indent correctly.