[webkit-reviews] review requested: [Bug 27517] Misc cleanup in DOM Storage. : [Attachment 33212] v1

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

Attachment 33212: v1
https://bugs.webkit.org/attachment.cgi?id=33212&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
The StorageAreaImpl changes are all for Chromium.  Because the DOM Storage
implementation runs in a different process from where the Frame object lives,
Chromium passes in NULL for the sourceFrame.  This affects events and handling
privateBrowsing.  Chromium's incognito mode does not use the private browsing
setting, so that's not a concern.  As for events, I've decided to simply
disable them for now.

The StorageNamespaceImpl changes get rid of a stale comment (path is .copy'ed
for thread-safety) and to add an assert that .copy is only ever called on a
SessionStorage namespace.