[webkit-reviews] review requested: [Bug 27508] Add checks for switch statement indentation to cpplint : [Attachment 33200] Add checks for switch statement indentation to cpplint (try 3)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 21 12:39:21 PDT 2009


Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27508: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27508

Attachment 33200: Add checks for switch statement indentation to cpplint (try
3)
https://bugs.webkit.org/attachment.cgi?id=33200&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Good point, I had not thought of that case. Here's a relatively simple solution
that'll work in pretty much all common cases, approach explained in the code
comments. Plus more test cases. Is that good enough, or does it need to be
perfect?


More information about the webkit-reviews mailing list