[webkit-reviews] review requested: [Bug 27432] add read-write access to HTMLOptionElement text under GObject bindings : [Attachment 33061] patch to make HTMLOptionElement text property read-write under gobject bindings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 21 12:26:46 PDT 2009


Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27432: add read-write access to HTMLOptionElement text under GObject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27432

Attachment 33061: patch to make HTMLOptionElement text property read-write
under gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33061&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
sorry, mark, but the reality is that existing applications expect to be able to
change text in <option> - that's supported _now_, not "in the future".

when webkit's javascript bindings remove write access to text, _then_ is the
time for the gobject bindings to _also_ have write access to text removed.

so whatever reasons apply to javascript supporting write-access to this
property, the exact same argument applies to the gobject bindings.

review- denied.  re-enabling review.  answer in next review is expected which
takes the above line of reasoning into account.


More information about the webkit-reviews mailing list