[webkit-reviews] review granted: [Bug 27462] Add cpplint check for proper include order : [Attachment 33191] New version that special cases 'FooCustom.cpp'

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Adam Treat <treat at kde.org>'s
request for review:
Bug 27462: Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Attachment 33191: New version that special cases 'FooCustom.cpp'
https://bugs.webkit.org/attachment.cgi?id=33191&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Would be nice to make s small adjustment on landing.

> +		   if filename.endswith('.h'):
> +		       error(filename, line_number, 'build/include_order', 4,
> +			     '%s Should be: alphabetically sorted.' %
> +			     (error_message))
No need for parens on error_message (since it is a single element).

Btw, wierd python-ism: the parens do nothing here :) 
to make it a tuple with one element you'd have to do this: (error_message,)
 


> +		   else:
> +		       error(filename, line_number, 'build/include_order', 4,
> +			     '%s Should be: config.h, primary header, blank
line, and then alphabetically sorted.' %
> +			     (error_message))

Same comment about (error_message)