[webkit-reviews] review granted: [Bug 27478] All DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject : [Attachment 33140] Update patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 21 10:19:06 PDT 2009
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27478: All DOMConstructorObjects should hold a pointer to the
JSDOMGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=27478
Attachment 33140: Update patch
https://bugs.webkit.org/attachment.cgi?id=33140&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch is awesome. Redundant code: BE GONE!
+ I've added two new classes: DOMObjectWithGlobalPointer and
DOMConstructorObjectInDocument.
The ChangeLog uses the old class names.
+ class DOMConstructorWithDocument : public DOMConstructorObject {
+ public:
+ Document* document() const
+ {
+ return static_cast<Document*>(scriptExecutionContext());
+ }
+ protected:
Missing a blank line here.
More information about the webkit-reviews
mailing list