[webkit-reviews] review denied: [Bug 27494] Crash/Unexpected behavior if call ScriptSourceCode::source on a CachedScript : [Attachment 33165] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 21 09:57:10 PDT 2009


Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33165: Patch
https://bugs.webkit.org/attachment.cgi?id=33165&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
The code looks good, but when you add a file to the project, you should really
add it to all the build systems.  I think you've missed WebCore.gypi for
example.   You should find "ScriptSourceCode.h" and make sure your new file
shows up in all the same places.


More information about the webkit-reviews mailing list