[webkit-reviews] review requested: [Bug 26838] Multithread support for JSC on UNIX : [Attachment 33173] WebKit-r46156-Collector-multithread-support-for-UNIX.diff

[bugzilla-daemon at webkit.org]

Martin Zoubek <martin.zoubek at acision.com> has asked  for review:
Bug 26838: Multithread support for JSC on UNIX
https://bugs.webkit.org/show_bug.cgi?id=26838

Attachment 33173: WebKit-r46156-Collector-multithread-support-for-UNIX.diff
https://bugs.webkit.org/attachment.cgi?id=33173&action=review

------- Additional Comments from Martin Zoubek <martin.zoubek at acision.com>
Hi Maciej,
thanks for your review. Changes since last version of the patch:
- SIG_THREAD_SUSPEND_RESUME becomes static const int
- pth_sig_suspend_resume was renamed
- unrelated check for registers size in Heap::markOtherThreadConservatively()
was removed, it is not needed
- signal handler was modified to use sigsuspend() instead of sigwait(), because
sigwait() is not async signal safe

Sunspider results:
1. Single threaded gtk+ build
before: 525.5ms +/- 0.4%
after: 524.8ms +/- 0.6% (no change)
2. Multi threaded gtk+ build
before: not buildable
after: 544.3ms +/- 0.7%

Tests were performed on Fedora 11 x86_64 in VMware machine.