[webkit-reviews] review denied: [Bug 26988] Haiku-specific files for WebCore : [Attachment 33166] Patch to add a first bunch of Haiku-specific files for WebCore.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 21 03:03:19 PDT 2009


David Levin <levin at chromium.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 33166: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=33166&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I want to approve this but this change isn't done.

 diff --git a/WebCore/platform/haiku/CursorHaiku.cpp
b/WebCore/platform/haiku/CursorHaiku.cpp
> +static Cursor
global_cursor(static_cast<PlatformCursor>(B_CURSOR_SYSTEM_DEFAULT));
> +static Cursor ibeam_cursor(static_cast<PlatformCursor>(B_CURSOR_I_BEAM));

As noted before: Improper casing 
   s/global_cursor/globalCursor/
   s/ibeam_cursor/ibeamCursor/


More information about the webkit-reviews mailing list