[webkit-reviews] review denied: [Bug 27366] TextEncodingDetector that uses Universal Charset Detector : [Attachment 32926] TextEncodingDetectorUniversal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 21 00:49:44 PDT 2009


Maciej Stachowiak <mjs at apple.com> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 27366: TextEncodingDetector that uses Universal Charset Detector
https://bugs.webkit.org/show_bug.cgi?id=27366

Attachment 32926: TextEncodingDetectorUniversal
https://bugs.webkit.org/attachment.cgi?id=32926&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
What's our plan for maintaining this code? Will we sync with upstream
periodically or maintain it ourselves? Either way, it seems like a bad idea to
put all the code in one file. It seems like it will make maintenance harder.
Please resubmit with files split properly. I have no comment on the merits as
to whether including this is a good idea, probably international text experts
should chime in. Is there any information available on Universal Charset
Detector, what it does, and how it works?


More information about the webkit-reviews mailing list