[webkit-reviews] review denied: [Bug 25463] Desktop Notifications API : [Attachment 32341] Notifications API, Tests and DumpRenderTree hooks
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 20 21:43:56 PDT 2009
Maciej Stachowiak <mjs at apple.com> has denied John Gregg <johnnyg at google.com>'s
request for review:
Bug 25463: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463
Attachment 32341: Notifications API, Tests and DumpRenderTree hooks
https://bugs.webkit.org/attachment.cgi?id=32341&action=review
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
First of all, I suggest combining this with the other patch. Yes, it will make
it overall a bit bigger, but it's a significant benefit to be able to land
atomically with test cases. I don't see any problems with the code (well done!)
but marking r- since this depends on the other patch, and since I suggest
combining with it.
More information about the webkit-reviews
mailing list