[webkit-reviews] review granted: [Bug 27479] Guard access to installedMediaEngines()[0] : [Attachment 33138] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 20 19:57:17 PDT 2009
Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 27479: Guard access to installedMediaEngines()[0]
https://bugs.webkit.org/show_bug.cgi?id=27479
Attachment 33138: patch
https://bugs.webkit.org/attachment.cgi?id=33138&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Ok. A coupel things to fix when landing.
The layout test should self-document (i.e. say something like: "PASSED -- crash
using Audio with no installed engines bug 27479")
The test needs a -expected.txt file from a layout tests run.
empty.wav belongs in the resources/ subdirectory.
You can fix those when landing.
Thanks!
More information about the webkit-reviews
mailing list