[webkit-reviews] review requested: [Bug 27323] Better support for non-Cygwin SVN on Windows : [Attachment 33131] Fixes, part 8

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 20 18:13:14 PDT 2009


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33131: Fixes, part 8
https://bugs.webkit.org/attachment.cgi?id=33131&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This implements abarth's suggestion of creating a centralized
determineSVNRoot() that multiple scripts can call.

The main goal of this is to use it in commit-log-editor, where the old code
resulted in commit logs like "../../../../../../JavaScriptCore:" in my hybrid
checkout.

ddkilzer said that darin has expressed a preference for keeping
svn-create-patch independent, which would imply copy-and-pasting this code
instead of (or in addition to?) putting it in VCSUtils.pm.  I can do either;
I'm biased against copy-and-pasting unless it's important.  Let me know.


More information about the webkit-reviews mailing list