[webkit-reviews] review denied: [Bug 22784] [Chromium] Home, End, PageUp and PageDown buttons do not do anything in drop down lists : [Attachment 33096] Updated, more focused patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 22784: [Chromium] Home, End, PageUp and PageDown buttons do not do anything
in drop down lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 33096: Updated, more focused patch
https://bugs.webkit.org/attachment.cgi?id=33096&action=review

------- Additional Comments from David Levin <levin at chromium.org>


> Index: WebCore/ChangeLog
> +	   No new tests; affects only user input handling.

(Now that I understand this better) It seems that a layout test could be added
for this functionality.  For example, see this test that simulates user input:
LayoutTests/fast/forms/input-text-enter.html

> Index: WebCore/dom/SelectElement.cpp
> +enum SkipDirection {
> +    kSkipBackwards = -1,
> +    kSkipForwards = 1
> +};
> +

Enum members should user InterCaps with an initial capital letter.  (No leading
"k". Also, just fyi, even for constants WebKit doesn't prefix them with "k". 
They follow the standard naming convention.)