[webkit-reviews] review denied: [Bug 27444] Wrong FrameLoader::activeDocumentLoader when loading an invalid URL. : [Attachment 33081] set the provisional documentLoader as the activeDocument in case of load failures (v0.1)

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 27444: Wrong FrameLoader::activeDocumentLoader when loading an invalid URL.
https://bugs.webkit.org/show_bug.cgi?id=27444

Attachment 33081: set the provisional documentLoader as the activeDocument in
case of load failures (v0.1)
https://bugs.webkit.org/attachment.cgi?id=33081&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Thanks for your interest and thanks for you patch, but I think you're chasing
down a non-issue.

Most importantly, a Frame shouldn't ever consider a failed, non-committed load
as it's current DocumentLoader.  Making this change would be a change in
behavior that many WebKit applications do not expect. Most notably, Safari
would break with this change.

Can you explain an example of an application you're working on where this
change is desirable?  And why?

Also, if a layout test times out with your patch in but runs correctly without
your patch, that *is* indicative of a regression with your patch.  I bet the
test is catching exactly the WebKit API breakage that I alluded to.