[webkit-reviews] review requested: [Bug 27275] [Chromium] popup menus can crash when the selected index is -1 : [Attachment 33102] Fix for crashing with invalid index.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 20 13:26:27 PDT 2009


Paul Godavari <paul at chromium.org> has asked  for review:
Bug 27275: [Chromium] popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Attachment 33102: Fix for crashing with invalid index.
https://bugs.webkit.org/attachment.cgi?id=33102&action=review

------- Additional Comments from Paul Godavari <paul at chromium.org>
Updated the code per previous review comments. Changed the check from "index ==
-1" to "index < 0" to be consistent with other PopupListBox methods.


More information about the webkit-reviews mailing list