[webkit-reviews] review denied: [Bug 27275] [Chromium] popup menus can crash when the selected index is -1 : [Attachment 32908] Updated fix for an invalid vector index crash

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Paul Godavari <paul at chromium.org>'s
request for review:
Bug 27275: [Chromium] popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Attachment 32908: Updated fix for an invalid vector index crash
https://bugs.webkit.org/attachment.cgi?id=32908&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This seems wrong:
     if (index < 0 || index >= numItems())
 890	     return;
 891 
888892	   if (index == -1 && m_popupClient) {

You've made some of the code unreachable.