[webkit-reviews] review denied: [Bug 27424] adding GStringBinding.h : [Attachment 33050] adds GStringConvert.h

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27424: adding GStringBinding.h
https://bugs.webkit.org/show_bug.cgi?id=27424

Attachment 33050: adds GStringConvert.h
https://bugs.webkit.org/attachment.cgi?id=33050&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
This is using WebCore types, so the above header file is internal, this means
you should follow the WebCore coding style guidelines, which you don't. The
first issue i notice is the placement of the '*'.

On the question of content, I wonder if the gdom/ directory is supposed to hold
public API as well? if that is the case you should put the GStringConvert
somewhere else, and calling it GStringConvert is a bit misleading as GString !=
gchar.

please revise.