[webkit-reviews] review denied: [Bug 27410] [Gtk] adding GObject Language bindings auto-generator : [Attachment 33038] absolute basic beginnings of CodeGeneratorGObject.pm.

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27410: [Gtk] adding GObject Language bindings auto-generator
https://bugs.webkit.org/show_bug.cgi?id=27410

Attachment 33038: absolute basic beginnings of CodeGeneratorGObject.pm. 
https://bugs.webkit.org/attachment.cgi?id=33038&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> +package CodeGeneratorGObject;
> +
> +require "CodeGeneratorGObjectLibrary1.pm";

This file doesn't exist as far as I can see.  What is it?  Why is it named in
this manner?

> +
> +# Params: 'domClass' struct

What is this comment about?  The "Params" suggests it is about the arguments to
the following function, but the function appears to take three arguments that
have no relation to this comment.

> +sub GenerateInterface {
> +    my $object = shift;
> +    my $dataNode = shift;
> +    my $defines = shift;
> +
> +    my $name = $dataNode->name;
> +
> +    print "$name\n";

What's the purpose of this print statement?

> +
> +    $object->Generate($dataNode);
> +
> +    # Write changes
> +    my $fname = "Gdom_" . $name; #decamelize($name);

The comment here doesn't seem to add anything.	Why is there commented-out code
here?

> +    $fname =~ s/_//g;
> +    $object->WriteData($fname);
> +}
> +
> +# Params: 'idlDocument' struct

Same comment as for the previous function applies to this comment.

Marking as r- due to these issues.