[webkit-reviews] review requested: [Bug 27430] adds glib / gobject bindings to webkit gtk port : [Attachment 33059] adds use of glib / gobject bindings to webkitwebframe

[bugzilla-daemon at webkit.org]

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27430: adds glib / gobject bindings to webkit gtk port
https://bugs.webkit.org/show_bug.cgi?id=27430

Attachment 33059: adds use of glib / gobject bindings to webkitwebframe
https://bugs.webkit.org/attachment.cgi?id=33059&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
this patch should be one of those that is applied almost aaabsolutely at the
end, once its dependent patches are landed.  the modifications to
webkitmarshal.list are also included here: somewhere along the line, in
compiling the glib / gobject bindings (most likely the signals) this extra
jobbie is needed.

the functions add in the essential "hooks" in order to actually get at the glib
/ gobjects available through the bindings.  it would be very nice if there were
less of them - but there are not.

missing from the list of functions here is things like
webkit_web_frame_create_text_document() and other such functions.

also - it's worth noting that now that GdomFrame exists, much of the
functionality provided in webkitwebframe.cpp is duplicated, and can be seen to
have been necessarily hard-coded!  the auto-generated functions of GdomFrame
now make that code redundant, and, with careful thought, it should be possible
to drop most of webkitwebframe.cpp.

one for the future.