[webkit-reviews] review requested: [Bug 27425] adding GDOMHTMLElementWrapperFactory[.cpp/.h] : [Attachment 33052] adds gdomhtmlelementwrapperfactory.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 19 13:28:49 PDT 2009
Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked for review:
Bug 27425: adding GDOMHTMLElementWrapperFactory[.cpp/.h]
https://bugs.webkit.org/show_bug.cgi?id=27425
Attachment 33052: adds gdomhtmlelementwrapperfactory.
https://bugs.webkit.org/attachment.cgi?id=33052&action=review
------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
these files have review comments on it (one key reason why they're submitted
under a separate bugreport).
from memory, the questions are:
* why is there "shouting" in it?
answer: because the original files, JSHTMLElementWrapperFactory.[cpp,h] from
which they're copied, also have "shouting" in them.
* why is this not auto-generated?
answer: because the auto-generator is written in a bug-ugly language called
perl, and it was easier to do a first revision by cut/paste using the advanced
editing features of vim than it was to mind-bend to yet another perl script [i
did try]. also, the exception handling has been completely ripped out of
CodeGeneratorGObject which makes this file quite different from its origins.
More information about the webkit-reviews
mailing list