[webkit-reviews] review denied: [Bug 27028] [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment 33043] use the enum in webkitwebview.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 19 13:00:38 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has denied Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 33043: use the enum in webkitwebview.h
https://bugs.webkit.org/attachment.cgi?id=33043&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +webcore_cppflags += \
> +	-I$(srcdir)/WebKit/gtk/
> +

This is a layering violation. WebCore should not depend on WebKit. It should go
through the *Client interface, or in the case of Pasteboard, should go through
PasteboardHelper. The previous patch was already doing that. Why the change?

r- because of the layering violation.


More information about the webkit-reviews mailing list