[webkit-reviews] review denied: [Bug 27324] Add ENABLE_RUBY to list of build options : [Attachment 32824] patch: add ENABLE_RUBY build option
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 19 00:29:20 PDT 2009
David Levin <levin at chromium.org> has denied Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 27324: Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324
Attachment 32824: patch: add ENABLE_RUBY build option
https://bugs.webkit.org/attachment.cgi?id=32824&action=review
------- Additional Comments from David Levin <levin at chromium.org>
Address the following few issues and I think it will be ready to land.
Two issues:
1. You appear to be missing changes to trunk/WebCore/GNUmakefile.am and
trunk/WebCore/WebCore.vcproj/WebCoreCommon.vsprops (see
http://trac.webkit.org/changeset/46021 for example changes to these files).
2. The changelog should have the following:
Date Name line
Reviewed by NOBODY (OOPS!).
>Bug Title<
>Bug Link<
Description of change.
a. Your change logs appears to be missing the items in ><
b. Your description line seems to need to be indented one more space.
More information about the webkit-reviews
mailing list