[webkit-reviews] review denied: [Bug 26620] Haiku WebKit port : [Attachment 32917] Modifications on WebKit source code to allow Haiku port.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32917: Modifications on WebKit source code to allow Haiku port.
https://bugs.webkit.org/attachment.cgi?id=32917&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> -#if !PLATFORM(WIN_OS) && !PLATFORM(SOLARIS) && !PLATFORM(SYMBIAN) &&
!COMPILER(RVCT)
> +#if !PLATFORM(WIN_OS) && !PLATFORM(SOLARIS) && !PLATFORM(SYMBIAN) &&
!COMPILER(RVCT) && !(HAIKU)
Should be !PLATFORM(HAIKU)

> --- a/WebCore/config.h
> +++ b/WebCore/config.h
> @@ -187,3 +187,7 @@ typedef float CGFloat;
>  #if PLATFORM(WIN) && PLATFORM(CG)
>  #define WTF_USE_SAFARI_THEME 1
>  #endif
> +
> +#if PLATFORM(HAIKU)
> +#include <stdio.h>
> +#endif
stdio.h should not be included in config.h