[webkit-reviews] review granted: [Bug 25523] The text displayed by push buttons is not exposed to assistive technologies : [Attachment 32946] Add new public method text() to RenderButton and use it from

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 17 19:48:15 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 25523: The text displayed by push buttons is not exposed to assistive
technologies
https://bugs.webkit.org/show_bug.cgi?id=25523

Attachment 32946: Add new public method text() to RenderButton and use it from
AccessibilityRenderObject::stringValue().
https://bugs.webkit.org/attachment.cgi?id=32946&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> -    
> +    const String text() const;
> +

I stand corrected and it should return a String not const String. The reason is
because RenderText::text() doesn't return a const String (RenderMenuList return
a String for RenderMenuList::text() as well, not const String).

r=me with changing it back to just String.


More information about the webkit-reviews mailing list