[webkit-reviews] review granted: [Bug 18363] [GTK] Combo boxes cannot be opened pressing space : [Attachment 33001] Make it if-elif-else-endif as suggested by Holger

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 33001: Make it if-elif-else-endif as suggested by Holger
https://bugs.webkit.org/attachment.cgi?id=33001&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
OKay, the next thing boils down to taste. To reduce code duplication one could
do

if (
#if SPACE_OR_..
keyCode == ' ' || keyCode == '\r'
#elif
keyCode == ' '
#endif
) {
  common Code
}