[webkit-reviews] review denied: [Bug 27351] [Qt] navigator.platform returns an empty string in Symbian and in Linux platforms : [Attachment 32911] Patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied	review:
Bug 27351: [Qt] navigator.platform returns an empty string in Symbian and in
Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=27351

Attachment 32911: Patch
https://bugs.webkit.org/attachment.cgi?id=32911&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

>  
>  String NavigatorBase::platform() const
>  {
> +#if PLATFORM(LINUX)
> +    struct utsname osname;
> +    int result = uname(&osname);
> +    String platformName;
> +    if (result >= 0) {
> +	   platformName = osname.sysname;
> +	   platformName += " ";
> +	   platformName += osname.machine;
> +    }
> +    return platformName;
> +#else
>      return WEBCORE_NAVIGATOR_PLATFORM;
> +#endif

Jan is right, we should call uname(&osname) exactly once. Yael could you post
an updated version of the patch?