[webkit-reviews] review granted: [Bug 14272] Cannot change the height of the Web Inspector when docked on Windows : [Attachment 32968] Resize Attach Height

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32968: Resize Attach Height
https://bugs.webkit.org/attachment.cgi?id=32968&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  void InspectorController::showWindow()
>  {
>      ASSERT(enabled());
> +
> +    unsigned inspectedPageHeight =
m_inspectedPage->mainFrame()->view()->visibleHeight();
> +
>      m_client->showWindow();
> +
> +    Setting attachedHeight = setting(inspectorAttachedHeightName);
> +    unsigned preferredHeight = attachedHeight.type() == Setting::IntegerType
? attachedHeight.integerValue() : defaultAttachedHeight;
> +
> +    // This call might not go through (if the window starts out detached),
but if the window is initially created attached,
> +    // InspectorController::attachWindow is never called, so we need to make
sure to set the attachedWindowHeight.
> +   
m_client->setAttachedWindowHeight(constrainedAttachedWindowHeight(preferredHeig
ht, inspectedPageHeight));

I think it's worth adding a FIXME here about cleaning this up so we can share
this logic with attachWindow.

This turned out really nicely. Thanks for doing all those revisions and working
out the bugs!

r=me