[webkit-reviews] review granted: [Bug 27383] [Chromium] Hook up V8 bindings for DataGrid elements : [Attachment 32985] 2nd patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 17 15:58:32 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Jens Alfke
<snej at chromium.org>'s request for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 32985: 2nd patch
https://bugs.webkit.org/attachment.cgi?id=32985&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Great! Just one nit:

> Index: WebCore/bindings/v8/custom/V8HTMLDataGridElementCustom.cpp
> ===================================================================
> --- WebCore/bindings/v8/custom/V8HTMLDataGridElementCustom.cpp       
(revision 46037)
> +++ WebCore/bindings/v8/custom/V8HTMLDataGridElementCustom.cpp       
(working copy)
> @@ -29,7 +29,9 @@
>   */
>  
>  #include "config.h"
> +#include "Document.h"
>  #include "HTMLDataGridElement.h"
> +#include "V8DataGridDataSource.h"
>  
>  #include "NotImplemented.h"

We don't need this one anymore, right?


More information about the webkit-reviews mailing list