[webkit-reviews] review requested: [Bug 27383] [Chromium] Hook up V8 bindings for DataGrid elements : [Attachment 32985] 2nd patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 17 15:53:28 PDT 2009


Jens Alfke <snej at chromium.org> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 32985: 2nd patch
https://bugs.webkit.org/attachment.cgi?id=32985&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
Changes in this patch:
At Dimitri's request I took out the #ifdef I added to DOMWindow.idl, and
instead fixed the V8 code generator to add #ifs around conditionally-enabled
attributes (in GenerateBatchedAttributeData).
This Perl function had really messed up indentation that obscured the flow of
control, so I fixed it; but that introduces a bunch of spurious diffs that are
just whitespace changes. Sorry about that (but I felt this needed fixing, as it
confused me on first reading.)


More information about the webkit-reviews mailing list