[webkit-reviews] review requested: [Bug 27375] [Chromium] Need a DOM_STORAGE guard in DerivedSourcesAllInOne.cpp : [Attachment 32957] v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 17 10:43:53 PDT 2009


Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27375: [Chromium] Need a DOM_STORAGE guard in DerivedSourcesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=27375

Attachment 32957: v1
https://bugs.webkit.org/attachment.cgi?id=32957&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp and
StorageEvent.cpp.  Unfortunately, until later this afternoon, DOM_STORAGE is
not turned on by default in Chromium, and so these two files are never
generated.  This breaks the compile.

There are no other instances of guards in the file, which puzzles me..but I
think adding guards is the right way to go about this.


More information about the webkit-reviews mailing list