[webkit-reviews] review denied: [Bug 25524] [Gtk] Expose the title attribute to assistive technologies : [Attachment 32933] Patch proposal, with ChangeLog

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 25524: [Gtk] Expose the title attribute to assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=25524

Attachment 32933: Patch proposal, with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32933&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +2009-07-17  Mario Sanchez Prada  <msanchez at igalia.com>
> +
> +	Reviewed by NOBODY (OOPS!).
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=25524
> +	[Gtk] Expose the title attribute to assistive technologies
> +
> +	Expose 'alt' attribute from images as accessible name.
> +	Expose the 'title' core HTML attribute as accessible description.
> +
> +	   * accessibility/AccessibilityRenderObject.cpp:
> +	   (WebCore::AccessibilityRenderObject::stringValue):
> +	   (WebCore::AccessibilityRenderObject::accessibilityDescription):
> +

The indentation here is completely off. You should align everything at 8 chars,
with no tabs at all.

> +	   if (node && node->isHTMLElement()) {
> +	       const AtomicString& alt =
static_cast<HTMLElement*>(node)->getAttribute(altAttr);
> +	       if (!alt.isEmpty())
> +		 return alt;

Bad indentation here (2 instead of 4 spaces). If you're using Emacs you may
want to do M-x set-variable <RET> c-basic-offset <RET> 4 <RET> =)

> +    } else {
> +	 Node* node = m_renderer->node();
> +	 if (node && node->isHTMLElement()) {
> +	   const AtomicString& title =
static_cast<HTMLElement*>(node)->getAttribute(titleAttr);
> +	   if (!title.isEmpty())
> +	     return title;
> +	 }

Bad indentation here too.

I could just fix this stuff myself, and commit, since the rest of the patch
looks good, but I'd like to have an updated patch submitted by you that I can
just apply and commit. Thanks for your work!