[webkit-reviews] review requested: [Bug 25523] [GTK] The text displayed by push buttons is not exposed to assistive technologies : [Attachment 32932] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25523: [GTK] The text displayed by push buttons is not exposed to assistive
technologies
https://bugs.webkit.org/show_bug.cgi?id=25523

Attachment 32932: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=32932&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
New version of the patch attached. Please notice it touches
platform-independent code, even though it's motivated because of a WebKitGtk
a11y bug.

(In reply to comment #7)
> > This can be inlined in RenderButton.h. And also, RenderButton::text()
should
> > return const String instead of just String.
> 
> I did it this way as that's how I've seen it's done in other places, such as
> RenderMenuList.[h|cpp]. Anyway, I've no problem in implementing it as an
inline
> funcion in the .h file if that's ok.

At last, I did not add the method as inline because its implementation relies
on the private attribute 'RenderTextFragment* m_buttonText'
(m_buttonText->text() is used) and that class is not available at compilation
time when compiling the RenderButton.h file, so it fails to compile. Therefore,
I've leave it as it was right now (same way than in RenderMenuList.[h|cpp]),
just adding the 'const' modifier to the return value of the function.