[webkit-reviews] review granted: [Bug 27359] [V8] Centralize hidden property names : [Attachment 32910] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 16 19:07:45 PDT 2009
David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27359: [V8] Centralize hidden property names
https://bugs.webkit.org/show_bug.cgi?id=27359
Attachment 32910: patch
https://bugs.webkit.org/attachment.cgi?id=32910&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/bindings/v8/V8HiddenPropertyName.cpp
> + static v8::Persistent<v8::String>* string = new
v8::Persistent<v8::String>(v8::Persistent<v8::String>::New(v8::String::NewSymbo
l(key)));
It seems a shame to repeat "new
v8::Persistent<v8::String>(v8::Persistent<v8::String>::New(v8::String::NewSymbo
l(key)))" twice already in this file.
What about a function so this line of code would look something like this
static v8::Persistent<v8::String>* string = createV8PeristentString(key)
?
More information about the webkit-reviews
mailing list