[webkit-reviews] review requested: [Bug 27358] [Qt] Fix the include path for the Symbian port : [Attachment 32907] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 16 17:36:29 PDT 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27358: [Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358

Attachment 32907: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32907&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Started as a build fix; ended up being a lot of cleanup.

This patch puts the system includes at the end of the include path, so that
when the include path is built up new (more specific) path elements are
prepended (and not appended) to the include path. For example the include path
for WebCore looks like this:
 - Qt port specific dirs
 - Port independent WebCore dirs
 - JavaScriptCore dirs
 - System includes.

In addition the patch includes the following cleanups:
 - Sorted the include lists
 - Fixed the Qt port specific include list (so that it only includes Qt port
specific dirs and it includes all of those)
 - Removed WebCore/ForwardingHeaders from WebCore include path (as
JavaScriptCore.pri is included). This should make the build a bit faster.

Tested on Linux/Windows/Symbian.


More information about the webkit-reviews mailing list