[webkit-reviews] review denied: [Bug 27318] Allow LocalStorage to be enabled without enabling SessionStorage : [Attachment 32897] v2

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27318: Allow LocalStorage to be enabled without enabling SessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27318

Attachment 32897: v2
https://bugs.webkit.org/attachment.cgi?id=32897&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks good, but two nits:

> -    Document* document = m_frame->document();
> +    Settings* settings = page->settings();
> +    if (!settings->sessionStorageEnabled())
> +	   return 0;

If settings isn't used by the rest of this function, then you don't need to
make a variable for it.

>      , m_localStorageEnabled(false)
> +    , m_sessionStorageEnabled(true)

Why do these have different defaults?