[webkit-reviews] review requested: [Bug 27327] [Chromium] Clean up v8 bindings a bit : [Attachment 32901] rev 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 16 16:41:02 PDT 2009


Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27327: [Chromium] Clean up v8 bindings a bit
https://bugs.webkit.org/show_bug.cgi?id=27327

Attachment 32901: rev 3
https://bugs.webkit.org/attachment.cgi?id=32901&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Made the change Mads suggested.

Also a disclaimer that I should have made earlier: I know nothing about the
Inspector, nothing about this code, and only some about the bindings in
general.  This stuff is definitely over my head.  I'm only doing it because
hitting the NOTIMPLEMENTED was blocking me from enabling DOM_STORAGE.  The
inspector has seemingly worked even after the previously buggy implementations,
so please take a close look before you r+ it.  That said, we really need to get
this in before we can go much further in enabling DOM storage.


More information about the webkit-reviews mailing list