[webkit-reviews] review requested: [Bug 27323] Better support for non-Cygwin SVN on Windows : [Attachment 32899] Fixes, part 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 16 16:05:53 PDT 2009


Peter Kasting <pkasting at google.com> has asked David Kilzer (ddkilzer)
<ddkilzer at webkit.org> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32899: Fixes, part 2
https://bugs.webkit.org/attachment.cgi?id=32899&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
ddkilzer: aroben suggested you were the right person to review this.

The motivation behind this is that it's possible for at least Chromium (perhaps
other ports) to have a layered checkout, with the top level being from the
Chromium repo and a subdirectory ("WebKit/") being from the WebKit repo.  This
makes it possible to test WK changes directly in a Chromium build and then
submit without having to copy things over to a separate checkout (error-prone).
 This works well except that svn-create-patch gets confused about the checkout
root, so here I modify the algorithm to halt when we see a different Repository
Root than we started with (or no root at all, if we're in a standalone WK
checkout).


More information about the webkit-reviews mailing list