[webkit-reviews] review granted: [Bug 27352] Video size sometimes jumps just after the video starts loading : [Attachment 32893] Patch, changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 16 14:41:28 PDT 2009


Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 27352: Video size sometimes jumps just after the video starts loading
https://bugs.webkit.org/show_bug.cgi?id=27352

Attachment 32893: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=32893&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    bool readyForRendering() const;

I think it would be slightly better to call this isReadyForRendering for two
reasons.

    1) "ready" is verb as well as an adjective.
    2) Without the "is", the function seems like it might be the caller saying
we are ready, rather than asking.

r=me


More information about the webkit-reviews mailing list