[webkit-reviews] review requested: [Bug 27329] Inspector: Properties Should be Sorted more Naturally : [Attachment 32873] AlphaNumSort (Like Finder on leading zeros)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 16 08:36:28 PDT 2009


Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 32873: AlphaNumSort (Like Finder on leading zeros)
https://bugs.webkit.org/attachment.cgi?id=32873&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Keishi liked Finder's sort the best.  And indeed that is probably the best
performing because it didn't require using any more regular expressions
(although it treats 0 as a special case, which is disappointing but possible to
do without regular expressions in the algorithm).  Give this one a shot.

And if you feel as though "!+chunk" is clearer as "!Number(chunk)" then please
change it.  I actually prefer the former.


More information about the webkit-reviews mailing list