[webkit-reviews] review denied: [Bug 25195] using keyboard to extend selection after a selection using mouse extends character selection in reverse order as FF and IE : [Attachment 31969] patch w/ Layout test

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 25195: using keyboard to extend selection after a selection using mouse
extends character selection in reverse order as FF and IE
https://bugs.webkit.org/show_bug.cgi?id=25195

Attachment 31969: patch w/ Layout test
https://bugs.webkit.org/attachment.cgi?id=31969&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Six thoughts:

    1) Please re-test this after http://trac.webkit.org/changeset/45945 -- this
might have been affected by that bug.

    2) #if !PLATFORM(WIN) is the way to do this, not an #if followed by an
#else.

    3) Does this really not affect the results of any other regression tests?

    4) We want the test to test behavior on all platforms, expecting one result
on Windows and another on other platforms.

    5) Is it really true that Windows is the exception? Maybe Mac is the
exception?

    6) In the test case, two of the comments have been merged into one giant
line. Search for "the mouse down" to see what I mean.