[webkit-reviews] review requested: [Bug 27347] HitTestResult::boundingBox can ASSERT in SVGRenderBase::mapLocalToContainer : [Attachment 32862] Make using HitTestResult on SVG not run into assertions

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 27347: HitTestResult::boundingBox can ASSERT in
SVGRenderBase::mapLocalToContainer
https://bugs.webkit.org/show_bug.cgi?id=27347

Attachment 32862: Make using HitTestResult on SVG not run into assertions
https://bugs.webkit.org/attachment.cgi?id=32862&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
WebCore
2009-07-03  Holger Hans Peter Freyther	<zecke at selfish.org>

Reviewed by NOBODY (OOPS!).

Change HitTest to use transform for SVGRenderBase

Kill HitTestResult::boundingBox as it doesn't belong into a
HitTest as it is operating on points.

Change HitTestResult::imageRect to use RenderBox::absoluteContentQuad
to useTransform. This is required to not run into an assert
with SVG Images in SVGRenderBase.

* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::imageRect):
* rendering/HitTestResult.h:

WebKit/win
2009-07-03  Holger Hans Peter Freyther	<zecke at selfish.org>

Reviewed by NOBODY (OOPS!).

HitTestResult::boundingBox is gone, use the RenderObject
directly and be transformation aware to not run into asserts
in SVGRenderBase.

* WebElementPropertyBag.cpp:
(WebElementPropertyBag::Read):

WebKit/qt
2009-07-03  Holger Hans Peter Freyther	<zecke at selfish.org>

Reviewed by NOBODY (OOPS!).

HitTestResult::boundingBox is gone, use the RenderObject
directly and be transformation aware to not run into asserts
in SVGRenderBase.

* Api/qwebframe.cpp:
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
---
 7 files changed, 44 insertions(+), 15 deletions(-)