[webkit-reviews] review denied: [Bug 27337] Add a getter in MessagePortChannel for the PlatformMessagePortChannel : [Attachment 32843] Proposed patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 27337: Add a getter in MessagePortChannel for the
PlatformMessagePortChannel
https://bugs.webkit.org/show_bug.cgi?id=27337

Attachment 32843: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32843&action=review

------- Additional Comments from David Levin <levin at chromium.org>
It would be nice to mention in the bug why this is useful.

> Index: WebCore/dom/MessagePortChannel.h
> +	   // Getter for m_channel.

I'd remove this comment as it doesn't really seem to add any information.

> +	   PassRefPtr<PlatformMessagePortChannel> channel();

Since this method isn't really passing the ref count to the caller (it retains
the ref counted pointer), just return PlatformMessagePortChannel* (instead of a
PassRefPtr).

Also, why not just define this inline?
     return m_channel.get();