[webkit-reviews] review denied: [Bug 26988] Haiku-specific files for WebCore : [Attachment 32308] Patch to add a sixth bunch of Haiku-specific files for WebCore.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32308: Patch to add a sixth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32308&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +double currentTime()
> +{
> +    struct timeval tv;
> +    struct timezone tz;
> +
> +    gettimeofday(&tv, &tz);
> +    return (double)tv.tv_sec + (double)(tv.tv_usec / 1000000.0);
Once again c++ style casts please :D

> +TranslatorDecoder::TranslatorDecoder()
> +{
> +    m_image = 0;
> +    setSize(-1,-1);
> +}
space after the ,

> +
> +bool TranslatorDecoder::isSizeAvailable() const
> +{
> +    return !(size() == IntSize(-1, -1));
> +}
Does != really not work here?

> +void TranslatorDecoder::setData(SharedBuffer* data, bool allDataReceived) 
> +{ 
> +    if(allDataReceived) {
> +	   BMemoryIO io(data->data(),data->size());
> +	   m_image = BTranslationUtils::GetBitmap(&io);
> +	   if (m_image) {
> +	       //set the image size decoded.
> +	       setSize(m_image->Bounds().Width() + 1,
m_image->Bounds().Height() + 1);
> +	   }   
Should not have braces around a single line if :D

> +void Widget::setFrameRect(const IntRect& rect)
> +{
> +    if (!platformWidget())
> +	   return;
> +
> +    if (frameRect() != rect){
Space before {