[webkit-reviews] review denied: [Bug 26988] Haiku-specific files for WebCore : [Attachment 32300] Patch to add a first bunch of Haiku-specific files for WebCore.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32300: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32300&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +// extensions beyond IE's API
> +HashSet<String> ClipboardHaiku::types() const 
> +{
> +    HashSet<String> result;
> +    BMessage *data;
> +
> +    if (be_clipboard->Lock()) {
> +	   if ((data = be_clipboard->Data())) {
> +	       char *name;
> +	       uint32 type;
> +	       int32 count;
> +
> +	       for (int32 i = 0;
> +		    data->GetInfo(B_ANY_TYPE, i, &name, &type, &count) == B_OK;

> +		    i++) {
> +		   result.add(name);
> +	       } 

This should be two lines:
	       for (int32 i = 0; data->GetInfo(B_ANY_TYPE, i, &name, &type,
&count) == B_OK; i++)
		   result.add(name);

> +bool ClipboardHaiku::hasData() 
> +{
> +    bool result = false;
> +    BMessage *data;
> +
> +    if (be_clipboard->Lock()) {
> +	   if ((data = be_clipboard->Data())) {
> +	       result = !data->IsEmpty();
> +	   }
This if-statement has a single line of code so should not have braces

Rest of the patch looks fine, but it's easier for us to do landing if we have a
set of correct patches to land